[#6439] Fix UI of repeat labels #6459
Conversation
| @@ -117,6 +117,7 @@ | |||
| <string name="add_repeat">Add</string> | |||
| <string name="dont_add_repeat">Do not add</string> | |||
| <string name="add_another_menu">Add another</string> | |||
| <string name="add_another_question">Add another?</string> | |||
There was a problem hiding this comment.
Not sure how translations are done. Did not see it in the readme also. Kindly advice.
|
Tried to look at the style guide mentioned here Line 44 in e828193 |
|
The UI looks good to me. I wait for the others to chime in on implementation. |
|
Hie @lognaturel just following up on this PR. |
|
Thanks, @karntrehan! We haven't forgotten about it and will try to get to it this week. In general, our review capacity is limited so we'll have to think about the best way to get you involved. Are there some specific things that you/Samagra are hoping to get into Collect or are you looking to help out generally? |
|
Thank you for the reply @lognaturel. I understand the limited bandwidth and the busy schedules. Please take your time.
It is just me, in my personal capacity, wanting to contribute back to the amazing product I have used daily and in any capacity I can. Maybe I can keep getting a deeper knowledge of the system and also help with PR reviews in the future. Please feel free to tag me in issues you think I can help fix. I have some time kept aside for contributions to ODK. Looking forward :) |
|
Thanks so much, @karntrehan! Excited to see what we can do together. |
collect_app/src/androidTest/java/org/odk/collect/android/feature/formentry/AddRepeatTest.java
Outdated
Show resolved
Hide resolved
collect_app/src/androidTest/java/org/odk/collect/android/feature/formentry/AddRepeatTest.java
Outdated
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/formentry/repeats/AddRepeatDialog.java
Show resolved
Hide resolved
Not sure of this. Let me check. My android studio auto formats before commits. Let me undo that. |
Closes #6439
Why is this the best possible solution? Were any other approaches considered?
Is a simple change. No approaches considered.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No regressions. Tests have been added. Need translations though.
Do we need any specific form for testing your changes? If so, please attach one.
Added in the code.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Not applicable
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still pass - Some are failing here without my changes as wellDateFormatsTest- NA